Removes kid presence verification #858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any problem with this PR ? |
auvipy
requested changes
Apr 11, 2023
| @@ -74,7 +74,7 @@ def get_signing_keys(self, refresh: bool = False) -> List[PyJWK]: | |||
| signing_keys = [ | |||
| jwk_set_key | |||
| for jwk_set_key in jwk_set.keys | |||
| if jwk_set_key.public_key_use in ["sig", None] and jwk_set_key.key_id | |||
| if jwk_set_key.public_key_use in ["sig", None] | |||
There was a problem hiding this comment.
is it possible to test this change?
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the RFC 7517, the
kidkey is optional.This PR removes the check for a non-None value.