Cleaning up batch tests #2
Open
+58
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-schlickmann
commented
Nov 12, 2025
| ApplicationJob.enqueue_after_transaction_commit = false if defined?(ApplicationJob.enqueue_after_transaction_commit) | ||
| SolidQueue.preserve_finished_jobs = true | ||
| SolidQueue::Batch.maintenance_queue_name = nil | ||
| end |
Author
There was a problem hiding this comment.
these removals in setup and teardown are happening because this is already being handled either in test_helper.rb or by the use of transactional tests
p-schlickmann
commented
Nov 12, 2025
| JobBuffer.add "Hi failure #{batch.id}!" | ||
| end | ||
| end | ||
|
|
Author
There was a problem hiding this comment.
just moving those jobs from the bottom to the top of the file
p-schlickmann
commented
Nov 12, 2025
| def job!(active_job) | ||
| SolidQueue::Job.find_by!(active_job_id: active_job.job_id) | ||
| skip_active_record_query_cache do | ||
| SolidQueue::Job.find_by!(active_job_id: active_job.job_id) |
Author
There was a problem hiding this comment.
this should be fine but I just wanted to make sure we are skipping active record query cache, as we do in other tests
p-schlickmann
commented
Nov 12, 2025
|
|
||
| class SolidQueue::BatchTest < ActiveSupport::TestCase | ||
| self.use_transactional_tests = false | ||
| class BatchCompletionJob < ApplicationJob |
Author
There was a problem hiding this comment.
I moved BatchCompletionJob here instead of a separate file, since it's only being used in this test
p-schlickmann
commented
Nov 12, 2025
Author
There was a problem hiding this comment.
wasn't being used anywhere
p-schlickmann
commented
Nov 12, 2025
Author
There was a problem hiding this comment.
moved to test/models/solid_queue/batch_test.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up our discussion at rails#142
These are some minimal improvements to the organization of the tests. Very great work with the batches @jpcamara !