Skip to content

Promote Slider and RangeSlider to core #4890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2025
Merged

Promote Slider and RangeSlider to core #4890

merged 4 commits into from
Apr 11, 2025

Conversation

tayyabataimur
Copy link
Contributor

Remove Slider and RangeSlider components from labs and promote them to core.

Copy link

changeset-bot bot commented Mar 24, 2025

🦋 Changeset detected

Latest commit: 5a9f7ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@salt-ds/lab Minor
@salt-ds/core Minor
@salt-ds/data-grid Patch
@salt-ds/countries Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 10:43am

@tayyabataimur tayyabataimur added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Mar 24, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Mar 24, 2025
@tayyabataimur tayyabataimur added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Mar 24, 2025
@tayyabataimur tayyabataimur marked this pull request as ready for review March 24, 2025 14:44
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Mar 24, 2025
@mark-tate
Copy link
Contributor

I pinged a question to @honey-chang ... we have 2 seperate docs for this component, does our sidebar need grouping ?

@tayyabataimur tayyabataimur marked this pull request as ready for review April 11, 2025 09:53
@tayyabataimur tayyabataimur added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Apr 11, 2025
origami-z
origami-z previously approved these changes Apr 11, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Apr 11, 2025
Fercas123
Fercas123 previously approved these changes Apr 11, 2025
@tayyabataimur tayyabataimur dismissed stale reviews from Fercas123 and origami-z via 5a9f7ef April 11, 2025 10:40
@tayyabataimur tayyabataimur added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Apr 11, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Apr 11, 2025
@tayyabataimur tayyabataimur merged commit 7fe2106 into main Apr 11, 2025
14 of 15 checks passed
@tayyabataimur tayyabataimur deleted the slider-core branch April 11, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants