Skip to content

Conversation

SO9010
Copy link
Collaborator

@SO9010 SO9010 commented Jun 13, 2025

This PR aims to add the playlist image, description and owner to the top of the playlist, much like on the top of Albums and Artists. This will be useful when users have been implemented so we can allow the user to navigate to other users by clicking on the username.

@SO9010 SO9010 changed the title Add playlist info (start) Add playlist info Jun 13, 2025
@SO9010 SO9010 marked this pull request as ready for review June 13, 2025 12:59
@SO9010 SO9010 requested a review from jacksongoode June 13, 2025 12:59
@SO9010
Copy link
Collaborator Author

SO9010 commented Jun 13, 2025

Hey @jacksongoode could you check this out #630 should get merged before this one. This is the start to being able to add the ability to view users

@SO9010
Copy link
Collaborator Author

SO9010 commented Jun 17, 2025

@jacksongoode any chance to have a quick look at this?

@jacksongoode
Copy link
Collaborator

jacksongoode commented Jun 19, 2025

Very cool! A few thoughts.

  • I think the playlist could function a little more like an album view rather than an artist view, so maybe we should make the image the same size as the album cover in the album view? We also have a ton of height there as a result given that most playlist descriptions are short.
  • Collaborative: false looks a little odd, we could either make it a different icon (we have a unique icon for playlists next to their name) or we just hide the case where its false and only show Collaborative when the playlist is collaborative.

Could you rebase on main?

@SO9010
Copy link
Collaborator Author

SO9010 commented Jun 19, 2025

Yes that makes sense, I agree. I will have time to do this in a few days!

@SO9010
Copy link
Collaborator Author

SO9010 commented Jun 20, 2025

Should look better now!

@jacksongoode
Copy link
Collaborator

jacksongoode commented Jun 20, 2025

I'll have a look tonight! It would also be great if you added a short description on the PR just to get a sense for historical record of what the PR does.

@SO9010
Copy link
Collaborator Author

SO9010 commented Jun 20, 2025

Done and thanks!

@jacksongoode
Copy link
Collaborator

jacksongoode commented Jun 20, 2025

Ok a few things,.

image

In the case of the album info, there is a artist name, date, and label. Also note the padding between the album art and the start of the left alignment. Is it possible to get the playlist created date? If so that would be nice info to add then we could have:

Creator name
January 1, 2025
10 tracks

Much more like the album view. I think this could make sense given that the description is not often included? Maybe this means we should just mimic the album format for the playlist view?

However there is a little annoyance given that when the description is long, it currently doesn't wrap. We could just keep it that way or implement wrapping for the last line (description).

image

I'm just kind of feeling the ":" are a little odd and out of place? Its nicer without the field name and colon.

@SO9010
Copy link
Collaborator Author

SO9010 commented Jun 20, 2025

Okay, that makes sense - I agree. I'm sure I can find an endpoint that provides the playlist creation date!

Personally, I don't think the cover would look good if it's too far to the right. For playlists, it aligns better with the text or the album covers. Also, unlike albums, playlists don't have track numbers.

That said, I'm happy to implement it your way if you'd prefer!

I agree with keeping the design almost the same as the albums, except for that one difference.

@jacksongoode
Copy link
Collaborator

Would you be up for me making a few changes and we can revert if you don't think they work?

@SO9010
Copy link
Collaborator Author

SO9010 commented Jun 21, 2025

Of course please do!

@jacksongoode
Copy link
Collaborator

I was trying this out and realized that maybe the collaborative label isn't accurate? Its always false for my playlists, even collaborative ones? Does it work for you?

@SO9010
Copy link
Collaborator Author

SO9010 commented Jun 23, 2025

Oh! I don't have any collaborative ones so I couldn't check!

@jacksongoode
Copy link
Collaborator

jacksongoode commented Jun 25, 2025

image

I made some changes to adapt a bit the last line will show if its public/private and if its collaborative that's added like "Public • Collaborative". @SO9010 what do you think? If you test & think its good feel free to merge!

Copy link
Collaborator

@jacksongoode jacksongoode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above ^

@SO9010
Copy link
Collaborator Author

SO9010 commented Jun 25, 2025

Looks much better, thank you! One thing though I am thinking some hierarchy to the text like the one for albums would look nice. It currently looks a bit flat if that makes sense. I will change that then ask you to check it out again :)

@SO9010
Copy link
Collaborator Author

SO9010 commented Jun 26, 2025

I think this look better! @jacksongoode just waiting for you final ok again now :)

image

@jacksongoode
Copy link
Collaborator

Looks good! Merge away!

@SO9010 SO9010 merged commit 7ad831d into main Jun 26, 2025
9 checks passed
@SO9010 SO9010 deleted the so9010/Add-playlist-info branch June 26, 2025 11:52
@SO9010 SO9010 mentioned this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants