Theme: make placeholder color darker#645
Merged
jacksongoode merged 2 commits intojpochyla:mainfrom Jun 19, 2025
Merged
Conversation
Hack? Moving configuration of placeholder color to each theme instead of in the main setup.
Contributor
Author
|
Maybe just make the placeholder color grey 300 instead of the grey 400 we have now (not make it independent) |
Collaborator
|
Thank you for taking this on, I think this looks better for sure and was about to do the same! It would be better that we not make them independent since the theme colors should be different respective to each theme (grey 300 is a different color on each). You can mark it ready for review when you feel the code is ready, please add some high quality screenshots once of the final UI. |
Contributor
Author
|
Cool, ok something like this with the variable under just setup changed to grey 300 |
Collaborator
SO9010
pushed a commit
that referenced
this pull request
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hack?
Moving configuration of placeholder color to each theme instead of in the main setup.
Could maybe be an IF.
Tries to fix: #644