Refactor to use Rust 1.58+ format string syntax#672
Merged
jacksongoode merged 9 commits intojpochyla:mainfrom Jul 15, 2025
Merged
Refactor to use Rust 1.58+ format string syntax#672jacksongoode merged 9 commits intojpochyla:mainfrom
jacksongoode merged 9 commits intojpochyla:mainfrom
Conversation
Replaces instances of format!(...) with positional arguments (e.g., format!("{}", var)) to the new Rust 1.58+ inline variable syntax (e.g., format!("{var}")). This change improves code readability and consistency across the codebase, and leverages modern Rust formatting features. No functional changes are introduced.
Collaborator
|
I think this is good, hoping the macOS build passes. |
jacksongoode
approved these changes
Jul 14, 2025
Collaborator
jacksongoode
left a comment
jacksongoode
left a comment
There was a problem hiding this comment.
Looks good, thanks for being so quick to this!
Contributor
Author
|
I will check tomorrow for mac os build |
Collaborator
|
For some reason we now need the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces instances of format!(...) with positional arguments (e.g., format!("{}", var)) to the new Rust 1.58+ inline variable syntax (e.g., format!("{var}")). This change improves code readability and consistency across the codebase, and leverages modern Rust formatting features. No functional changes are introduced.
This fix Github Action Code style. (Not sure this is usefull)