Skip to content

Conversation

SO9010
Copy link
Collaborator

@SO9010 SO9010 commented Jul 14, 2025

Fixes #669.

@jacksongoode could you quickly look though this.

@jacksongoode
Copy link
Collaborator

How did you discover that this works?

https://docs.rs/ureq/latest/ureq/struct.RequestBuilder.html#method.force_send_body

This seems like a workaround method? Are there other instances of the Spotify API requiring this on other projects?

@SO9010
Copy link
Collaborator Author

SO9010 commented Jul 14, 2025

Uh on the Spotify page it says that it requires a body to be sent with it, but normally ureq doesnt support bodies to be sent with delete unless force send body is added. I think thats a new thing with ureq3. There is still not a complete consensus on how delete bodies should be handled, most of the time they are just ignored.

Copy link
Collaborator

@jacksongoode jacksongoode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! Weird but confirmed with Spotify's API.

@jacksongoode jacksongoode merged commit 9753953 into main Jul 14, 2025
6 of 8 checks passed
@jacksongoode jacksongoode deleted the Fix-saving/removing-items branch July 14, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Saving/removing track to/from library is broken

2 participants