Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add includes babel plugin option for node module whitelist #468

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeongshin
Copy link

Summary

Suggestion for babel plugin option for node module package whitelist

Problem

I'm building my ui-kit npm ui library powered by unistyles v3-beta.4

When ui-kit is added as node modules dependency to my app, current version unistyle babel plugin is skipping transforming.

So I'm getting errors below even though Stylesheet.configure is done.

Screenshot 2024-12-26 at 4 29 33 PM

Suggestion

How about adding includes option to whitelist node modules package that should be transformed using unistyles?

[
      // add custom packages to be transformed
      'react-native-unistyles/plugin', { includes: ['@jeongshin/ui-kit'] }
 ],

It works fine when I tested on my local project.

Thanks for great great library. 🙌

Copy link

vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-unistyles-2.0 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 7:55am
react-native-unistyles-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 7:55am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant