fix: emit theme change when theme is updated

[Brentlok]

Summary

fixes #869

Summary by CodeRabbit

• Bug Fixes
  • Fixed an issue where theme-dependent listeners were not immediately notified after a theme update. Listeners now receive change notifications as soon as the theme is updated.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-unistyles-2.0	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 17, 2025 5:38am
react-native-unistyles-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 17, 2025 5:38am

[coderabbitai]

Walkthrough

The updateTheme method in the UnistylesRuntime class was updated to emit a change event for the Theme dependency immediately after the theme is updated in the internal state. No changes were made to exported or public entity declarations.

Changes

Files	Change Summary
src/web/runtime.ts	Added emission of a change event for the Theme dependency after updating the theme in the state.

Possibly related PRs

• fix: updateTheme update cssvars #816: Modifies the internal theme update logic in the same updateTheme method, handling CSS variable conversion and CSS state updates.

Suggested reviewers

• jpudysz

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Commit Unit Tests in branch fix/update-theme-useUnistyles
• Post Copyable Unit Tests in Comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/web/runtime.ts (1)

217-219: Re-order emitChange to guarantee CSS is ready before listeners react

Emitting the Theme change before css.recreate() means any listener that re-renders immediately could do so while the DOM styles are still outdated, risking a brief flash of incorrect styles. Swapping the order keeps the behaviour consistent with the synchronous CSS update path and avoids that race:

-        this.services.listener.emitChange(UnistyleDependency.Theme)
 ...
-            this.services.registry.css.recreate()
+            this.services.registry.css.recreate()
+            this.services.listener.emitChange(UnistyleDependency.Theme)

Worth double-checking if any consumer relies on the current sequence; otherwise this reorder is safer.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b7d1d7 and 8e52391.

📒 Files selected for processing (1)

• src/web/runtime.ts (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/web/runtime.ts (1)

src/specs/index.native.ts (1)

• UnistyleDependency (15-15)