fix: root view background color setup

[jpudysz]

Summary

Summary by CodeRabbit

• Refactor
  • Improved internal handling of background color assignment for root view, ensuring more consistent color processing. No visible changes to user-facing features.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-unistyles-2.0	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 8, 2025 8:39am
react-native-unistyles-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 8, 2025 8:39am

[coderabbitai]

Walkthrough

The pull request updates the assignment and implementation of the internal method _setRootViewBackgroundColor within the HybridUnistylesRuntime object. It changes the reference of _setRootViewBackgroundColor to point to the newly defined setRootViewBackgroundColor function and adjusts the internal call to pass a parsed color value without a type assertion.

Changes

Files/Paths	Change Summary
src/specs/UnistylesRuntime/index.ts	Changed _setRootViewBackgroundColor assignment to reference setRootViewBackgroundColor function; updated internal call to _setRootViewBackgroundColor to pass parsed color without type assertion; kept parameter optional.

Possibly related PRs

• refactor: remove invalid assignment to correctly set rootViewBackgroundColor #894: Both PRs modify the assignment and handling of _setRootViewBackgroundColor and setRootViewBackgroundColor within the same file, focusing on correcting and refining their references and calls.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 35e55cb and 451198b.

📒 Files selected for processing (1)

• src/specs/UnistylesRuntime/index.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/specs/UnistylesRuntime/index.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: lint

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/root-background-color

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/specs/UnistylesRuntime/index.ts (1)

49-53: Consider aligning interface with implementation for type consistency.

The wrapper implementation correctly processes the color string using processColor and provides a sensible fallback value of 0. However, there's a type inconsistency to address:

• The interface (line 26) declares _setRootViewBackgroundColor(color?: Color): void (optional Color)
• The implementation always passes a number (never undefined)

Consider updating the interface to reflect the actual usage:

-_setRootViewBackgroundColor(color?: Color): void
+_setRootViewBackgroundColor(color: number): void

This would better represent that the private method always receives a processed numeric color value.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b758392 and 35e55cb.

📒 Files selected for processing (1)

• src/specs/UnistylesRuntime/index.ts (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/specs/UnistylesRuntime/index.ts (5)

cxx/hybridObjects/HybridUnistylesRuntime.h (2)

• HybridUnistylesRuntime (16-17)
• color (68-68)

nitrogen/generated/shared/c++/HybridUnistylesRuntimeSpec.hpp (1)

• color (84-84)

nitrogen/generated/android/c++/JHybridNativePlatformSpec.hpp (1)

• color (64-64)

nitrogen/generated/shared/c++/HybridNativePlatformSpec.hpp (1)

• color (80-80)

nitrogen/generated/ios/c++/HybridNativePlatformSpecSwift.hpp (2)

• color (157-162)
• color (157-157)

🔇 Additional comments (2)

src/specs/UnistylesRuntime/index.ts (2)

47-47: LGTM: Correct backup pattern for method wrapping.

The assignment correctly backs up the original setRootViewBackgroundColor method before redefining it, which is a standard pattern for method wrapping.

---

52-52: LGTM: Correct call to the backed up native method.

The call to _setRootViewBackgroundColor with the processed color value is correct. The processColor function properly converts the color string to a number format expected by the native layer, with 0 as a reasonable fallback for invalid or missing colors.