Skip to content

fix: improve no theme error messages #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

Conversation

Brentlok
Copy link
Collaborator

@Brentlok Brentlok commented Jul 11, 2025

Summary

Summary by CodeRabbit

  • Bug Fixes
    • Improved error messages when no theme is registered or selected, making it clearer how to resolve missing theme issues.
    • Enhanced error handling to provide more specific feedback if a requested theme is not found.

Copy link

coderabbitai bot commented Jul 11, 2025

Walkthrough

The internal logic of the getTheme method in the UnistylesRuntime class was updated to include more granular error handling. It now checks for the existence of registered themes and a valid theme name before attempting to retrieve a theme, returning specific error proxies for each failure scenario.

Changes

Files Change Summary
src/web/runtime.ts Enhanced getTheme logic with stepwise error handling: checks for registered themes, theme name, and theme existence, returning specific error proxies for each case.

Possibly related PRs

Suggested reviewers

  • jpudysz

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6e094fb and af25e04.

📒 Files selected for processing (1)
  • src/web/runtime.ts (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/web/runtime.ts (2)
src/types/core.ts (1)
  • UnistylesTheme (48-48)
src/web/utils/common.ts (1)
  • error (10-10)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: lint
🔇 Additional comments (4)
src/web/runtime.ts (4)

245-246: LGTM: Clear variable naming for theme existence check.

The hasSomeThemes variable clearly indicates the intent to check if any themes have been registered, improving code readability.


247-253: Excellent improvement: Specific error for missing theme configuration.

This error case provides a clear, actionable message when no themes have been registered at all. The suggestion to call StyleSheet.configure is helpful for developers who may have forgotten this setup step.


255-261: Great addition: Handles missing theme name scenario.

This addresses the case where themes exist but no specific theme name is provided. The error message appropriately suggests selecting an initial theme, which is different from the previous scenario.


267-267: Correct logic simplification.

The condition is now appropriately simplified to only check !theme since !themeName is handled in the separate check above. This maintains the existing behavior for when a specific theme is not found.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch improve-notheme-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Jul 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-unistyles-2.0 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2025 6:36am
react-native-unistyles-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2025 6:36am

@Brentlok Brentlok merged commit 2b62f30 into main Jul 11, 2025
5 checks passed
@Brentlok Brentlok deleted the improve-notheme-error branch July 11, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants