-
-
Notifications
You must be signed in to change notification settings - Fork 79
docs: add explanation about theme access in StyleSheet.create API and web error #916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughAn informational aside was added to the tutorial documentation, explaining how to access the theme object when using Unistyles' StyleSheet compared to the standard React Native API. The aside also provides guidance for users encountering issues on the web platform and clarifies the focus on iOS support in the tutorial. Changes
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/src/content/docs/v3/tutorial/cleanup-screens.mdx (2)
145-147
: Use the same code-fence metadata pattern used elsewhereOther snippets in this doc use the
title="<path>" lang="tsx"
syntax.
Keeping the pattern consistent avoids rendering quirks in Starlight and helps readers quickly spot the file path.-```tsx /theme/ +```tsx title="/theme" lang="tsx"
152-154
: Provide a direct link to the web-setup guide or the referenced issuesReaders hitting the web error will appreciate an immediate pointer instead of having to search. Consider adding links to the future web-setup section or directly to issues #913 and #904.
Example:
For now, focus on iOS. We'll show you how to get it working on the web later — see [our web setup guide](../web-setup) or follow progress in [#913](https://github.com/jpudysz/react-native-unistyles/issues/913) and [#904](https://github.com/jpudysz/react-native-unistyles/issues/904).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/src/content/docs/v3/tutorial/cleanup-screens.mdx
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: lint
Summary
Explains better web error while following tutorial.
Fixes:
Summary by CodeRabbit