-
-
Notifications
You must be signed in to change notification settings - Fork 79
feat: add debugPrintFollyDynamic helper to debug shadow tree updates #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughA new inline function, Changes
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
cxx/common/Helpers.h (1)
321-366
: Consider adding error handling for dynamic type conversion.The parser lambda handles most
folly::dynamic
types correctly, but consider adding error handling around type conversions to prevent potential crashes during debugging.For safer type handling, consider wrapping the conversions:
if (value.isBool()) { - std::string output = key + ": " + (value.getBool() ? "true" : "false"); + std::string output = key + ": " + (value.asBool() ? "true" : "false"); log.call(rt, output); return; }Also, consider adding a try-catch block around the type conversions to handle any unexpected cases gracefully during debugging.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
example/ios/Podfile.lock
is excluded by!**/*.lock
📒 Files selected for processing (1)
cxx/common/Helpers.h
(1 hunks)
🔇 Additional comments (2)
cxx/common/Helpers.h (2)
317-319
: Good implementation approach - consistent with existing patterns.The function signature and console setup follow the established patterns in the codebase, maintaining consistency with the existing
debugPrintJSIObject
function.
368-378
: Proper header/footer structure and root object handling.The main logic correctly handles both object and non-object root values, and the header/footer structure matches the existing JSI debug function pattern.
Summary
Summary by CodeRabbit