Skip to content

fix: map autoProcessPaths values to platform path #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

NichoCM
Copy link
Contributor

@NichoCM NichoCM commented Jul 15, 2025

On Windows, setting the autoProcessPaths react-native-unstyles/plugin config does not work, meaning importing 3rd party component libraries that use react-native-unistyles are not transformed. This is a fix for that, using the already built-in toPlatformPath function to ensure windows paths are converted correctly (i.e use backslashes instead of forward slashes).

Summary

While trying to install an npm package I made that uses Unistyles under the hood to style components, I noticed the components were not properly being transform when they implemented a StyleSheet. As you would expect, files in the node_modules were not by default being transformed - but the documentation specifies a workaround for this: https://www.unistyl.es/v3/other/babel-plugin#autoprocesspaths.

The problem was, I could not get it working. So I looked at the plugin code, and noticed that while I was defining my paths as @somepackage/components, the plugin's state.filename was in this format: C:\someproject\node_modules\@somepackage\components. The plugin already had a utility function (toPlatformPath) that converted the paths in the REPLACE_WITH_UNISTYLES_PATHS to support Windows paths, but this was not applied to the autoProcessPaths values.

This PR simply ensures both the REPLACE_WITH_UNISTYLES_PATHS and autoProcessPaths are converted to the correct format on Windows.

Just an aside, I really love Unistyles! Thank you for such a wonderful project.

Summary by CodeRabbit

  • Refactor
    • Improved the internal logic for determining file processing conditions, resulting in more consistent behavior when handling file paths. No changes to user-facing features or functionality.

On Windows, setting the autoProcessPaths react-native-unstyles/plugin config does not work, meaning importing 3rd party component libraries that use react-native-unistyles are not transformed. This is a fix for that, using the already built-in `toPlatformPath` function to ensure windows paths are converted correctly (i.e use backslashes instead of forward slashes).
Copy link

vercel bot commented Jul 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-unistyles-2.0 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2025 2:17am
react-native-unistyles-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2025 2:17am

Copy link

coderabbitai bot commented Jul 15, 2025

Walkthrough

The change updates the sequence of operations used to determine if a file should be processed with the replaceWithUnistyles flag. It now concatenates path arrays before normalizing them, instead of normalizing first and then concatenating, affecting how file paths are checked during processing.

Changes

Files Change Summary
plugin/index.js, plugin/src/index.ts Reordered operations: now concatenates path arrays before mapping with toPlatformPath for path checks.

Suggested reviewers

  • jpudysz

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0204a5c and d1f28ff.

📒 Files selected for processing (2)
  • plugin/index.js (1 hunks)
  • plugin/src/index.ts (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (2)
plugin/index.js (2)
plugin/src/consts.ts (1)
  • REPLACE_WITH_UNISTYLES_PATHS (30-33)
plugin/src/paths.ts (1)
  • toPlatformPath (9-13)
plugin/src/index.ts (1)
plugin/src/paths.ts (1)
  • toPlatformPath (9-13)
🔇 Additional comments (2)
plugin/src/index.ts (1)

36-39: LGTM! Critical fix for Windows path compatibility.

This change correctly addresses the Windows compatibility issue by ensuring that autoProcessPaths values are also converted to platform-specific paths using toPlatformPath. Previously, only REPLACE_WITH_UNISTYLES_PATHS were normalized, causing path matching to fail on Windows when state.filename (Windows-style) was compared against unnormalized autoProcessPaths (Unix-style).

plugin/index.js (1)

732-732: LGTM! Compiled version correctly mirrors the TypeScript fix.

This change in the compiled JavaScript file correctly implements the same Windows path compatibility fix as the TypeScript source. The logic now ensures that both REPLACE_WITH_UNISTYLES_PATHS and autoProcessPaths are properly normalized to platform-specific paths before path matching.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jpudysz
Copy link
Owner

jpudysz commented Jul 15, 2025

Great catch! Thank you for the PR

@jpudysz jpudysz merged commit dfd753e into jpudysz:main Jul 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants