fix: infinite loop with setRootViewBackgroundColor

[jpudysz]

Summary

Summary by CodeRabbit

• Refactor
  • Renamed the method for setting the root view background color throughout the app to ensure consistent naming. No changes to functionality or user-facing behavior.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-unistyles-2.0	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 16, 2025 11:19am
react-native-unistyles-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 16, 2025 11:19am

[coderabbitai]

Walkthrough

This change renames the method for setting the root view background color from various forms of setRootViewBackgroundColor or _setRootViewBackgroundColor to nativeSetRootViewBackgroundColor across C++ and TypeScript code, updating all declarations, implementations, mocks, and references to use the new name.

Changes

Files/Paths	Change Summary
cxx/hybridObjects/HybridUnistylesRuntime.cpp, cxx/hybridObjects/HybridUnistylesRuntime.h	Renamed method setRootViewBackgroundColor to nativeSetRootViewBackgroundColor in implementation and declaration.
src/specs/UnistylesRuntime/UnistylesRuntime.nitro.ts	Renamed interface method setRootViewBackgroundColor to nativeSetRootViewBackgroundColor.
src/specs/UnistylesRuntime/index.ts	Renamed private method and all references from _setRootViewBackgroundColor to nativeSetRootViewBackgroundColor; updated method calls accordingly.
src/mocks.ts	Renamed mock method _setRootViewBackgroundColor to nativeSetRootViewBackgroundColor.

Possibly related PRs

• refactor: remove invalid assignment to correctly set rootViewBackgroundColor #894: Both PRs modify the handling and naming of the method responsible for setting the root view background color in HybridUnistylesRuntime, with the main PR renaming the method to nativeSetRootViewBackgroundColor and updating related references, while the retrieved PR removes an invalid assignment related to _setRootViewBackgroundColor in the same context.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dfd753e and f4eb08d.

⛔ Files ignored due to path filters (2)

• nitrogen/generated/shared/c++/HybridUnistylesRuntimeSpec.cpp is excluded by !**/generated/**
• nitrogen/generated/shared/c++/HybridUnistylesRuntimeSpec.hpp is excluded by !**/generated/**

📒 Files selected for processing (5)

• cxx/hybridObjects/HybridUnistylesRuntime.cpp (1 hunks)
• cxx/hybridObjects/HybridUnistylesRuntime.h (1 hunks)
• src/mocks.ts (1 hunks)
• src/specs/UnistylesRuntime/UnistylesRuntime.nitro.ts (1 hunks)
• src/specs/UnistylesRuntime/index.ts (3 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (4)

cxx/hybridObjects/HybridUnistylesRuntime.cpp (6)

cxx/hybridObjects/HybridUnistylesRuntime.h (1)

• color (68-68)

cxx/core/UnistylesState.h (1)

• color (34-34)

nitrogen/generated/android/c++/JHybridNativePlatformSpec.hpp (1)

• color (64-64)

nitrogen/generated/ios/c++/HybridNativePlatformSpecSwift.hpp (2)

• color (157-162)
• color (157-157)

nitrogen/generated/shared/c++/HybridNativePlatformSpec.hpp (1)

• color (80-80)

nitrogen/generated/shared/c++/HybridUnistylesRuntimeSpec.hpp (1)

• color (84-84)

src/specs/UnistylesRuntime/UnistylesRuntime.nitro.ts (6)

cxx/hybridObjects/HybridUnistylesRuntime.h (1)

• color (68-68)

cxx/core/UnistylesState.h (1)

• color (34-34)

nitrogen/generated/android/c++/JHybridNativePlatformSpec.hpp (1)

• color (64-64)

nitrogen/generated/ios/c++/HybridNativePlatformSpecSwift.hpp (2)

• color (157-162)
• color (157-157)

nitrogen/generated/shared/c++/HybridNativePlatformSpec.hpp (1)

• color (80-80)

nitrogen/generated/shared/c++/HybridUnistylesRuntimeSpec.hpp (1)

• color (84-84)

cxx/hybridObjects/HybridUnistylesRuntime.h (3)

nitrogen/generated/ios/c++/HybridNativePlatformSpecSwift.hpp (2)

• color (157-162)
• color (157-157)

nitrogen/generated/shared/c++/HybridNativePlatformSpec.hpp (1)

• color (80-80)

nitrogen/generated/shared/c++/HybridUnistylesRuntimeSpec.hpp (1)

• color (84-84)

src/specs/UnistylesRuntime/index.ts (5)

cxx/hybridObjects/HybridUnistylesRuntime.h (2)

• color (68-68)
• HybridUnistylesRuntime (16-17)

nitrogen/generated/android/c++/JHybridNativePlatformSpec.hpp (1)

• color (64-64)

nitrogen/generated/ios/c++/HybridNativePlatformSpecSwift.hpp (2)

• color (157-162)
• color (157-157)

nitrogen/generated/shared/c++/HybridUnistylesRuntimeSpec.hpp (1)

• color (84-84)

src/specs/types.ts (1)

• Color (38-38)

🔇 Additional comments (7)

src/specs/UnistylesRuntime/UnistylesRuntime.nitro.ts (1)

45-45: Good renaming to fix infinite loop issue.

The method rename from setRootViewBackgroundColor to nativeSetRootViewBackgroundColor creates a clear distinction between the public API method and the native implementation, which should resolve the infinite loop mentioned in the PR title.

cxx/hybridObjects/HybridUnistylesRuntime.cpp (1)

189-191: Correctly implements the infinite loop fix.

The method rename to nativeSetRootViewBackgroundColor while maintaining the correct forwarding to _nativePlatform->setRootViewBackgroundColor(color) properly separates the hybrid runtime method from the platform implementation, breaking any potential infinite loop.

src/mocks.ts (1)

101-101: Mock updated to match interface changes.

The Jest mock correctly reflects the method rename to nativeSetRootViewBackgroundColor, ensuring test compatibility with the infinite loop fix.

cxx/hybridObjects/HybridUnistylesRuntime.h (1)

68-68: Header declaration correctly updated.

The method declaration rename to nativeSetRootViewBackgroundColor matches the implementation and properly overrides the base class method, maintaining consistency across the C++ codebase.

src/specs/UnistylesRuntime/index.ts (3)

26-26: Interface correctly updated with new native method.

The addition of nativeSetRootViewBackgroundColor(color?: Color): void to the UnistylesRuntimePrivate interface properly reflects the renamed native method.

---

38-38: Private method correctly added to exclusion list.

Adding nativeSetRootViewBackgroundColor to the PrivateMethods type ensures it's excluded from the public API, maintaining proper encapsulation.

---

48-52: Infinite loop fix correctly implemented.

The public setRootViewBackgroundColor method now properly processes the color and calls the renamed native method nativeSetRootViewBackgroundColor, breaking the infinite loop that likely existed when both methods had the same name.

The color processing logic with processColor(color) ?? 0 ensures proper conversion from string to number format expected by the native method.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/rootviewbackground

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.