Skip to content

feat: add dedicated breakpoint dependency handler to skip sealed check #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025

Conversation

jpudysz
Copy link
Owner

@jpudysz jpudysz commented Jul 17, 2025

Summary

Fixes #921

Summary by CodeRabbit

  • Refactor
    • Improved how breakpoint dependencies are managed internally, resulting in more consistent handling of breakpoint-related features. There are no visible changes to the user experience.

Copy link

coderabbitai bot commented Jul 17, 2025

"""

Walkthrough

A new method, addBreakpointDependency(), was added to the Unistyle struct to register breakpoint dependencies without checking if the instance is sealed. All usages in the parser were updated to use this new method instead of the previous addDependency() approach, specifically when handling breakpoint-based values.

Changes

Files Change Summary
cxx/core/Unistyle.h Added addBreakpointDependency() method to Unistyle struct.
cxx/parser/Parser.cpp Replaced calls to addDependency(UnistyleDependency::BREAKPOINTS) with addBreakpointDependency().

Assessment against linked issues

Objective Addressed Explanation
Ensure breakpoint-based values update correctly when used inside variants (#921)
Avoid sealed check for breakpoint dependency registration related to dynamic React component updates (#921)

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes were found.
"""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5754344 and 8ff5fa9.

📒 Files selected for processing (2)
  • cxx/core/Unistyle.h (1 hunks)
  • cxx/parser/Parser.cpp (3 hunks)
✅ Files skipped from review due to trivial changes (1)
  • cxx/parser/Parser.cpp
🚧 Files skipped from review as they are similar to previous changes (1)
  • cxx/core/Unistyle.h
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/breakpoints

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Jul 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-unistyles-2.0 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2025 0:28am
react-native-unistyles-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2025 0:28am

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6dd1296 and 5754344.

📒 Files selected for processing (2)
  • cxx/core/Unistyle.h (1 hunks)
  • cxx/parser/Parser.cpp (3 hunks)
🔇 Additional comments (1)
cxx/parser/Parser.cpp (1)

671-744: All old breakpoint dependency calls have been removed

I ran the following searches and found no remaining usages of the old
addDependency(UnistyleDependency::BREAKPOINTS) pattern:

  • rg "addDependency.*BREAKPOINTS" --type cpp — no matches
  • rg "addDependency.*[Bb]reakpoint" --type cpp — no matches

This confirms that all instances have been updated to the new addBreakpointDependnecy() method. No further changes are needed.

@jpudysz jpudysz merged commit bb8013f into main Jul 17, 2025
5 checks passed
@jpudysz jpudysz deleted the feature/breakpoints branch July 17, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Values based on breakpoints not updating when used in variant
1 participant