fix: preserve numerical precision on unary negation #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itchyny
force-pushed
the
unary-negation-preserve-precision
branch
from
14eb4a8 to
ed38840
Compare
itchyny
changed the title
itchyny
force-pushed
the
unary-negation-preserve-precision
branch
3 times, most recently
from
20a5e0a to
1e58b2f
Compare
wader
reviewed
Feb 3, 2025
| @@ -571,19 +570,18 @@ static jvp_literal_number* jvp_literal_number_alloc(unsigned literal_length) { | |||
| + sizeof(decNumberUnit) * units | |||
| ); | |||
|
|
|||
| n->refcnt = JV_REFCNT_INIT; | |||
| n->num_double = NAN; | |||
| n->literal_data = NULL; | |||
There was a problem hiding this comment.
What was the reson to move this from new to alloc?
Looks like jvp_literal_number_new is the only user of jvp_literal_number_alloc, maybe could be merged or keep separate for readability?
There was a problem hiding this comment.
Also used for negate.
|
Nice! have some vague memory of trying to fix this just for constant literals by changing the lexer to include the |
wader
approved these changes
Feb 3, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #2704.