Add --output-file flag for writing values to file
#3410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to write the output to a file and introduces the options -o and --output-file that take a filename as parameter. When not specifying -o, stdout will be used for compatibility. This will be helpful when calling jq inside a docker context as it means jq will not have to be called from within a shell with output redirection.
To enable instantiating multiple VMs, instead pass ofile when needed. There is only one use of jv_dump outside of tests, bytecode dumps, and tracing; pass ofile to it.
thaliaarchi
force-pushed
the
output-file
branch
from
c81d1e3 to
7bf1484
Compare
When both --binary is given before --output-file, the file wasn't marked as binary. When checking whether stdout is a TTY, it didn't handle --output-file.
thaliaarchi
force-pushed
the
output-file
branch
from
b0bfb27 to
7f6e10f
Compare
|
Well that was a lot of back and forth with CI to identify the problem with Windows 😅. I'm confident in this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a further development on @christf's #3367 (feat: allow writing to output file), which handles some edge cases not considered.
Other uses of stdout, such as tests, fuzzers, disassembly, and debug traces, remain directed to stdout; only JSON values are written to the output file. Consequently, users of
--debug-dump-disasmand--debug-tracecan now separate the debug and JSON outputs. On Windows, the output file is marked as binary when--binaryis passed.This incorporates the commit from #3367, but with minor fixes squashed in.
Fixes #2418
Closes #3367