Fix problems with spaces in path names under windows #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/warbler-pre-release-tillsc.rb
Outdated
| @@ -0,0 +1 @@ | |||
| require 'warbler' | |||
There was a problem hiding this comment.
I guess this wasn't meant to go into the commit, but was a way of testing out the change locally.
There was a problem hiding this comment.
You're absolutely right. Sorry... Is't a bit hard to test since the :git bundler dependencies aren't working...
lib/warbler/version.rb
Outdated
| @@ -6,5 +6,5 @@ | |||
| #++ | |||
|
|
|||
| module Warbler | |||
| VERSION = "2.0.5" | |||
| VERSION = "2.0.5-pre" | |||
There was a problem hiding this comment.
I guess this wasn't meant to go into the commit, but was a way of testing out the change locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid
IllegalArgumentExceptionfromnew URI(...)by usinggetRawSchemeSpecificPart()to preserve correct escaping (e.g., for spaces inProgram Files).This occurred for example when running
java -jar "my_app.war" -S rake -Tunder windows.I left
this.pathunchanged because it's unclear what other parts of the code expect there.Instead, I extract a separate
pathWithoutMainfor URI construction.