Skip to content

Conversation

@platypii
Copy link
Contributor

I was trying to use JSCAD to extrude an SVG into a 3d object and was frustrated that it didn't handle holes right.

This fixes the long standing issue of svg holes (#1087, #888, #1253)

Before:
Screenshot 2025-08-17 at 13 54 52

After:
Screenshot 2025-08-17 at 13 55 01

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

Note: please do NOT include build files (those generate by the build-xxx commands) with your PR,

Thank you for your help in advance, much appreciated !

@platypii platypii requested review from hrgdavor and z3dev August 17, 2025 21:00
Copy link
Contributor

@hrgdavor hrgdavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat fix. I expected it to be more complicated to fix. Thanks for tackling this annoying set of bugs. :)

@hrgdavor
Copy link
Contributor

I tried to be useful at least in some way, so I googled what could be cause of failing node16 CI workflow.

possibly changing .github\workflows\node.yml and there actions/setup-node@v2 -> actions/setup-node@v4

this is not a bug in this PR ofc., just a CI issue.

@z3dev
Copy link
Member

z3dev commented Aug 19, 2025

@platypii Thanks for the fixes. I won't be able to review / merger until this weekend. But I was going to make releases this weekend anyway. So, hopefully this will be included.

@z3dev
Copy link
Member

z3dev commented Aug 23, 2025

@platypii the last performance changes had some fixes to the github workflows. can you sync your repo with V3? i think that will correct the build errors.

Or make a small change to restart the builds?

Copy link
Member

@z3dev z3dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

@z3dev z3dev merged commit e642de4 into jscad:V3 Aug 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants