Conversation
Contributor
|
The changes seem fine, but I don't love the idea of adding a dependency to modeling package. Right now it has zero dependencies which is pretty nice? |
Member
Author
Tis nice. But the duplicate functions are kind of lame. The array-util functions can also be exported as part of the modeling API as well. Anyway, this dependency can be added anytime. Now, I just want to make this package (array-utils) into one of the major packages, rather than hiding under utils. |
platypii
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes promote array-utils to a general package. The coalease() function from modeling has been added, as well as tested.
These are in preparation to using array-utils as a dependency in modeling, i.e. drop duplicate functions in modeling.
All Submissions: