modeling: breaking changes in geom3 #1412
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes break V2 compatibility in the geometries as the compact binary functions have been removed. It was good idea but became unnecessary and over complicated.
Also, geom3 has been updated to use toVertices() and fromVertices(), which follows the new internal and external naming standards for the geometries.
Lot of test cases need adjustments as well.
All Submissions: