Skip to content

Conversation

@z3dev
Copy link
Member

@z3dev z3dev commented Dec 7, 2025

These changes break V2 compatibility in the geometries as the compact binary functions have been removed. It was good idea but became unnecessary and over complicated.

Also, geom3 has been updated to use toVertices() and fromVertices(), which follows the new internal and external naming standards for the geometries.

Lot of test cases need adjustments as well.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

@z3dev z3dev requested review from hrgdavor and platypii December 7, 2025 00:50
Copy link
Contributor

@hrgdavor hrgdavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the addition of fromVerticesConvex. No objections to rest of the changes.

Copy link
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@z3dev z3dev merged commit ab78f6d into V3 Dec 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants