Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dtrt-indent-set #84

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Conversation

ramnes
Copy link
Contributor

@ramnes ramnes commented Jun 15, 2024

Closes #82

@ramnes ramnes force-pushed the dtrt-indent-set branch from eec903f to b692a27 Compare June 15, 2024 19:12
@ramnes ramnes changed the title Implement dtrt-indent-set Implement dtrt-indent-set Jun 15, 2024
@rrthomas
Copy link
Collaborator

Wow, this is great! Thanks for doing this.

What would you think about having a message if no variable can be found, when the function is called interactively? Would be nice to warn/explain to the user who might otherwise be confused when it has no effect.

@ramnes
Copy link
Contributor Author

ramnes commented Jun 17, 2024

Why not, but then ideally we'd want to error before prompting the user for an offset, and I'm not sure how to do that. I'll eventually take a deeper look when I have some time to spare. :)

@rrthomas
Copy link
Collaborator

I think giving an error is the main thing, so while you're right, I don't think that matters, and I'd rather land the PR sooner; so, I'd be quite happy with just having a message output when there's no setting variable found and the function is called interactively.

@ramnes ramnes force-pushed the dtrt-indent-set branch from 2e0184b to abd4340 Compare June 23, 2024 09:24
@ramnes
Copy link
Contributor Author

ramnes commented Jun 23, 2024

@rrthomas done then :)

@ramnes ramnes force-pushed the dtrt-indent-set branch from abd4340 to b8da4ac Compare June 23, 2024 09:32
@ramnes ramnes force-pushed the dtrt-indent-set branch from b8da4ac to 32fbb74 Compare June 23, 2024 09:34
@rrthomas rrthomas merged commit 2b0bcf6 into jscheid:master Jun 23, 2024
2 checks passed
@rrthomas
Copy link
Collaborator

Many thanks! New release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dtrt-indent-set
2 participants