-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: e2e tests #55
feat: e2e tests #55
Conversation
5385147
to
a310e07
Compare
So when working on something just in this repo, to run the test, we'd have to push the changes, create a matching branch in the other repo, and then run it from there? Can't we do something like in the probe repo, where config files with |
If your version of
We can, but in requires at least 2 .env files, to update It will also require some updates to the init scripts, to support .env files override, and I am not sure all that complications will make e2e tests easier to run. |
Ok that seems fine then, just document it later in #53. |
Fixes #47
Local run of e2e tests from that repo was not added, as it would add a lot of mess to support editable local env vars (e.g. specifying
DIRECTUS_URL=http://localhost:18055
instead ofDIRECTUS_URL=http://127.0.0.1:18055
).Tests still can be executed locally from https://github.com/jsdelivr/globalping-dash-directus. Since those 2 repos always goes hand in hand, I think that is ok to run e2e tests from there. That PR adds execution on CI.