Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom type text/x-php #358

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add custom type text/x-php #358

wants to merge 1 commit into from

Conversation

cjiso1117
Copy link

Add support for text/x-php since file command use text/x-php in debian system

ref: https://cweiske.de/tagebuch/php-mimetype.htm#linux

@cjiso1117
Update custom-types.json
0593ba0 
add support for text/x-php
@cjiso1117
Copy link
Author

is PR review stuck due to broken automation?

@wesleytodd
Copy link
Member

No I think it was stuck due to no one reviewing it. That said, if you look here you see application/x-httpd-php which is already in our data. That article is from 2011 and I am not sure it justifies adding this type.

@cjiso1117
Copy link
Author

cjiso1117 commented Mar 6, 2025 •
edited
Loading

But file command returns text/x-php for most os in 2025, and some mimetype guessers depend on file command and system's mimetype database.

wesleytodd
wesleytodd requested changes Mar 7, 2025
View reviewed changes
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that is a valid argument. Can you add the source key with your research links?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleytodd wesleytodd wesleytodd requested changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjiso1117 @wesleytodd @bjohansebas