Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MIME Types for Apple .ipa and .plist extensions #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danilo-santana-e-silva
Copy link

From: Distribute proprietary in-house apps to Apple devices
Ref: https://support.apple.com/en-gb/guide/deployment/depce7cefc4d/1/web#dep30d16db76

"You may need to configure your web server so the manifest file and app file are transmitted correctly. For the server, add the MIME types to the web service’s MIME types settings:

application/octet-stream ipa
text/xml plist"

From: Distribute proprietary in-house apps to Apple devices
Ref: https://support.apple.com/en-gb/guide/deployment/depce7cefc4d/1/web#dep30d16db76

"You may need to configure your web server so the manifest file and app file are transmitted correctly. For the server, add the MIME types to the web service’s MIME types settings:

application/octet-stream ipa
text/xml plist"
@@ -939,7 +940,8 @@
]
},
"text/xml": {
"compressible": true
"compressible": true,
"extensions": ["plist"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, actually I am not sure what the impact is of adding this extension here. I think this is incorrect, but would like more eyes here. Maybe I am missing something.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be safe to add it, this is the diff it makes:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any precedent for this though. There are bunches of examples of files with custom extention's which are actually another format (xml, json, etc) that are not doing this. Why would we make a special case for this one?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! If I may, I'd like to clarify my reasoning.

I've submitted this PR to request the inclusion of two MIME type linkages with their associated file extensions. However, I acknowledge that I'm not fully familiar with the project yet, and it's possible I may have implemented the changes incorrectly.

My intent is simply to publish some Apple iOS files on GitHub Pages, which uses db-mime. For more details on MIME types and their handling on GitHub Pages, you can refer to the official documentation here: GitHub Pages MIME Types.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, and based on the docs from apple, it looks like they should have used a suffix and a specific mime type, not call this a text/xml. That would have made it more clear to me what is going on, and you can see plenty of examples of this in our current dataset. For example:

  "application/atom+xml": {
    "source": "iana",
    "compressible": true,
    "extensions": ["atom"]
  },

It is clear to me that they have documented it this way, and that as long as we prefer the xml extension first that it should be alright to add for the use cases we have in the express project. That said, I am concerned enough with this that I would like to ping in @dougwilson and get his opinion. Maybe I am being overly concerned, but since I cannot find another example like this I want to be extra careful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I was reviewing another PR and I think this might be a similar case to this one:

  "application/octet-stream": {
    "source": "iana",
    "compressible": false,
    "extensions": ["bin","dms","lrf","mar","so","dist","distz","pkg","bpk","dump","elc","deploy","exe","dll","deb","dmg","iso","img","msi","msp","msm","buffer"]
  },

As you can see here, lots of different extentions listed like you are adding to this one. I had been looking specifically at xml examples (and did a quick search for json when I couldn't find any xml ones) but this seems to me to be the same use case, and so sets the precident I was looking to find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants