-
Notifications
You must be signed in to change notification settings - Fork 138
🧪 add engines test #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
🧪 add engines test #136
Conversation
I don't fully understand your change. How does that fix the original problem? Are we going to release a new major version? |
@bjohansebas as mentioned in the issue, we are not going to release a new major just for an engines change. what is your understanding of the "original problem"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
I think this is the right call for this situation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach 💯! But just one minor thing when we say "node": ">=18"
in the pkg we will get the last 18.x version not the name: get minimum node version
that technically is 18.0.0
🤔
Said that, I am happy with this change. Thanks @ctcpip for working on this ❤️
I'm okay with adding that step in the CI, but is the engine change going to be merged? That's what I don't understand. |
@UlisesGascon yep! that's true.. this additional test is just to check if we missed updating the engines field, and not truly to validate that it works in the earliest possible supported release of node. we decided a while ago to unpin our CI so that runs will always use whatever GH fetches as the latest version of the major. technically, we would not know about any break in 18.0.0, 19.0.0, 20.0.0, etc. if we are concerned about that (and I don't think we are), we would want to address that in our regular CI job @bjohansebas yes, the engine change is going to be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am good with this as is for now, but ideally we will get this all a bit more wrapped up (ideally in shared workflows) so that we don't bring back the problem of duplicated CI config with bash like this across all the repos. Not a blocker, and not even really a short term goal until we figure out automated publishing via. Just wanted to call out that we should be careful when propagating this pattern to other repos.
failing engines test before engines change with 0.6: https://github.com/jshttp/mime-types/actions/runs/14111833661/job/39532276468?pr=136
passing engines test after engines change to 18: https://github.com/jshttp/mime-types/actions/runs/14111854628/job/39532350886?pr=136
resolves #135