👷 add upstream change detection #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjohansebas
reviewed
Jul 2, 2025
bjohansebas
approved these changes
Jul 3, 2025
SGTM if someone else wants to do the work! 😄 |
|
I can do it once this is merged. |
jonchurch
reviewed
Jul 7, 2025
wesleytodd
approved these changes
Jul 7, 2025
| const knownWriteHeadHash = '281e0d02084a69893b8c3b8692e3c7c4de2ce22a626217fcf597fa6ddf6955a9' | ||
| const knownSetHeaderHash = '2d4f95e92586d28bfd4d3137a8eaacb82b255967d8c26413015c6b56daf0afe7' | ||
| const knownAppendHeaderHash = '0deb9f70c3bba63993321cca9281fb4607e2567bed1436b8574c5b86698125a8' | ||
| const knownRemoveHeaderHash = '3ad5ccb0a858beb6268f281492bd8d42c9815f5316cc3c4f7f735e142fcd29d9' |
There was a problem hiding this comment.
Could we add some automation to update these after a change is looked into? Just to make it easier than copy pasting the new value from the failed build?
There was a problem hiding this comment.
sure, should be a straight-forward follow-on.
jonchurch
approved these changes
Jul 7, 2025
wesleytodd
reviewed
Jul 7, 2025
Co-authored-by: Wes Todd <[email protected]>
… run before merging Co-authored-by: Jon Church <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need to know when node makes changes to these methods
open to better ideas though! 😆