Skip to content

Conversation

@708yamaguchi
Copy link
Member

By this pull request, ROS_MASTER_URI is set to localhost in *robot*_play.sh. (e.g. pr2_play.sh)
This program will prevent launching rosbag play node in master robot.

Merge after #1611

@708yamaguchi 708yamaguchi requested a review from iory December 10, 2018 08:26
@k-okada
Copy link
Member

k-okada commented Feb 22, 2019

Did you consider writing something like

<launch>                                                                                                               
  <arg name="ROS_MASTER_URI" default="$(env ROS_MASTER_URI)" />
  <env name="ROS_MASTER_URI" value="$(arg ROS_MASTER_URI)" />
</launch>

I am not so confident, so there might be a drowback.

@k-okada
Copy link
Member

k-okada commented Apr 25, 2019

waiting for feedback @708yamaguchi @iory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants