Skip to content

Commit 9087486

Browse files
authoredApr 5, 2024
Merge pull request #2821 from pazeshun/fix_test_2817
[jsk_pcl_ros] Fix errors on test_octomap_server_contact_pr2.test
2 parents 6f2b856 + 952c35e commit 9087486

5 files changed

+35
-4
lines changed
 

‎jsk_pcl_ros/CMakeLists.txt

+1
Original file line numberDiff line numberDiff line change
@@ -659,6 +659,7 @@ if (CATKIN_ENABLE_TESTING)
659659
if(tf2_eigen_FOUND)
660660
add_rostest(test/test_container_occupancy_detector.test)
661661
endif()
662+
add_rostest(test/test_octomap_server_contact_pr2.test)
662663
endif()
663664
roslaunch_add_file_check(launch/openni_local.launch)
664665
roslaunch_add_file_check(launch/openni2_local.launch)

‎jsk_pcl_ros/package.xml

+5
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
<exec_depend>image_transport</exec_depend>
5151
<exec_depend>image_view2</exec_depend>
5252
<exec_depend>interactive_markers</exec_depend>
53+
<exec_depend>joint_state_publisher</exec_depend>
5354
<exec_depend>jsk_data</exec_depend>
5455
<exec_depend>jsk_footstep_msgs</exec_depend>
5556
<exec_depend>jsk_interactive_marker</exec_depend>
@@ -73,12 +74,15 @@
7374
<exec_depend>pcl_conversions</exec_depend>
7475
<exec_depend>pcl_msgs</exec_depend>
7576
<exec_depend>pcl_ros</exec_depend>
77+
<exec_depend>pr2_description</exec_depend>
7678
<exec_depend condition="$ROS_PYTHON_VERSION == 2">python-sklearn</exec_depend>
7779
<exec_depend condition="$ROS_PYTHON_VERSION == 3">python3-sklearn</exec_depend>
7880
<exec_depend>resized_image_transport</exec_depend>
7981
<exec_depend>robot_self_filter</exec_depend>
82+
<exec_depend>robot_state_publisher</exec_depend>
8083
<exec_depend>rosboost_cfg</exec_depend>
8184
<exec_depend>roscpp_tutorials</exec_depend>
85+
<exec_depend>roseus</exec_depend>
8286
<exec_depend>sensor_msgs</exec_depend>
8387
<exec_depend>std_msgs</exec_depend>
8488
<exec_depend>std_srvs</exec_depend>
@@ -89,6 +93,7 @@
8993
<exec_depend>tf_conversions</exec_depend>
9094
<exec_depend>topic_tools</exec_depend>
9195
<exec_depend>visualization_msgs</exec_depend>
96+
<exec_depend>xacro</exec_depend>
9297
<exec_depend>yaml-cpp</exec_depend>
9398

9499
<test_depend>compressed_depth_image_transport</test_depend>

‎jsk_pcl_ros/sample/include/play_rosbag_pr2_sink.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<arg name="LOAD_URDF" default="false"/>
33

44
<param name="/use_sim_time" value="true"/>
5-
<param name="robot_description" command="$(find xacro)/xacro.py '$(find pr2_description)/robots/pr2.urdf.xacro'"
5+
<param name="robot_description" command="$(find xacro)/xacro '$(find pr2_description)/robots/pr2.urdf.xacro'"
66
if="$(arg LOAD_URDF)"/>
77

88
<node name="rosbag_play" pkg="rosbag" type="play"

‎jsk_pcl_ros/sample/sample_octomap_server_contact_pr2.launch

+5-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
<launch>
2-
<param name="robot_description" command="$(find xacro)/xacro.py '$(find pr2_description)/robots/pr2.urdf.xacro'"/>
2+
<arg name="use_gui" default="true" doc="argument to launch rviz" />
3+
4+
<param name="robot_description" command="$(find xacro)/xacro '$(find pr2_description)/robots/pr2.urdf.xacro'"/>
35

46
<node name="joint_state_publisher" pkg="joint_state_publisher" type="joint_state_publisher">
5-
<param name="use_gui" value="true"/>
7+
<param name="use_gui" value="$(arg use_gui)"/>
68
</node>
79

810
<node name="robot_state_publisher" pkg="robot_state_publisher" type="robot_state_publisher"
@@ -62,6 +64,6 @@
6264
<node pkg="jsk_pcl_ros" type="test_contact_sensor.py" name="test_contact_sensor"
6365
output="screen" />
6466

65-
<node pkg="rviz" type="rviz" name="rviz"
67+
<node pkg="rviz" type="rviz" name="rviz" if="$(arg use_gui)"
6668
args="-d $(find jsk_pcl_ros)/config/octomap_server_contact_pr2.rviz" />
6769
</launch>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
<launch>
2+
<include file="$(find jsk_pcl_ros)/sample/sample_octomap_server_contact_pr2.launch" >
3+
<arg name="use_gui" value="false" />
4+
</include>
5+
6+
<test test-name="test_octomap_server_contact_pr2"
7+
name="test_octomap_server_contact_pr2"
8+
pkg="jsk_tools" type="test_topic_published.py"
9+
retry="3">
10+
<rosparam>
11+
topic_0: /occupied_cells_vis_array
12+
timeout_0: 30
13+
topic_1: /free_cells_vis_array
14+
timeout_1: 30
15+
topic_2: /unknown_cells_vis_array
16+
timeout_2: 30
17+
topic_3: /octomap_full
18+
timeout_3: 30
19+
topic_4: /octomap_binary
20+
timeout_4: 30
21+
</rosparam>
22+
</test>
23+
</launch>

0 commit comments

Comments
 (0)