Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into openapi #1624

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Merge master into openapi #1624

merged 3 commits into from
Oct 21, 2024

Conversation

bkoelman
Copy link
Member

Merges the master branch into openapi, which provides third-party JSON:API extensions support.

… content negotation and exposure of the active extensions (#1623)

Bugfix: always require Accept header in atomic:operations requests
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 90.53498% with 23 lines in your changes missing coverage. Please review.

Project coverage is 90.49%. Comparing base (2fd9263) to head (32f7515).
Report is 4 commits behind head on openapi.

Files with missing lines Patch % Lines
...c/JsonApiDotNetCore/Middleware/JsonApiMediaType.cs 92.95% 5 Missing ⚠️
...iDotNetCore/Middleware/JsonApiContentNegotiator.cs 95.29% 2 Missing and 2 partials ⚠️
...c/JsonApiDotNetCore/Middleware/JsonApiExtension.cs 73.33% 3 Missing and 1 partial ⚠️
.../JsonApiDotNetCore/Middleware/JsonApiMiddleware.cs 88.23% 2 Missing and 2 partials ⚠️
...uckle/JsonApiActionDescriptorCollectionProvider.cs 57.14% 1 Missing and 2 partials ⚠️
src/JsonApiDotNetCore/CollectionExtensions.cs 60.00% 1 Missing and 1 partial ⚠️
...washbuckle/JsonApiRequestFormatMetadataProvider.cs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           openapi    #1624      +/-   ##
===========================================
- Coverage    90.55%   90.49%   -0.06%     
===========================================
  Files          455      458       +3     
  Lines        13729    13861     +132     
  Branches      2116     2147      +31     
===========================================
+ Hits         12432    12544     +112     
- Misses         882      896      +14     
- Partials       415      421       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review October 21, 2024 21:52
@bkoelman bkoelman merged commit 9657947 into openapi Oct 21, 2024
16 checks passed
@bkoelman bkoelman deleted the merge-master-into-openapi branch October 21, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant