Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource inheritance with atomic operations #1628

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

bkoelman
Copy link
Member

Fixed: If an operation is enabled on a base type, it should implicitly be enabled on all derived types.

QUALITY CHECKLIST

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.72%. Comparing base (661afb3) to head (aa763bf).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...NetCore/AtomicOperations/DefaultOperationFilter.cs 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1628      +/-   ##
==========================================
- Coverage   90.72%   90.72%   -0.01%     
==========================================
  Files         352      352              
  Lines       11438    11447       +9     
  Branches     1879     1881       +2     
==========================================
+ Hits        10377    10385       +8     
  Misses        695      695              
- Partials      366      367       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review November 10, 2024 21:07
@bkoelman bkoelman merged commit 43c1a4b into master Nov 10, 2024
16 checks passed
@bkoelman bkoelman deleted the fix-operations-inheritance branch November 10, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant