Solved #2305 External X (Twitter) Profile Link Opens in Same Tab Instead of New Tab #2310
Solved #2305 External X (Twitter) Profile Link Opens in Same Tab Instead of New Tab #2310Surajiitmjnu wants to merge 1 commit intojson-schema-org:mainfrom
Conversation
|
Hi @Surajiitmjnu! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
|
Hi @Surajiitmjnu! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference, kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2310 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 633 672 +39
Branches 196 211 +15
=========================================
+ Hits 633 672 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @Surajiitmjnu! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference, kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
1 similar comment
|
Hi @Surajiitmjnu! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference, kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
What kind of change does this PR introduce?
Bugfix
Closes #2305
Screenshots/videos:
suraj_revie.mp4
Summary
This PR fixes an issue where clicking on a sponsor's X (Twitter) handle opened the external link in the same browser tab.
The fix adds
target="_blank"andrel="noopener noreferrer"to ensure external links open in a new tab while following security best practices.This improves user experience by allowing users to remain on the JSON Schema website while viewing external profiles.
Does this PR introduce a breaking change?
No