Skip to content

Solved #2305 External X (Twitter) Profile Link Opens in Same Tab Instead of New Tab #2310

Open
Surajiitmjnu wants to merge 1 commit intojson-schema-org:mainfrom
Surajiitmjnu:#2305
Open

Solved #2305 External X (Twitter) Profile Link Opens in Same Tab Instead of New Tab #2310
Surajiitmjnu wants to merge 1 commit intojson-schema-org:mainfrom
Surajiitmjnu:#2305

Conversation

@Surajiitmjnu
Copy link
Contributor

@Surajiitmjnu Surajiitmjnu commented Mar 3, 2026

What kind of change does this PR introduce?

Bugfix

Closes #2305

Screenshots/videos:

suraj_revie.mp4

Summary

This PR fixes an issue where clicking on a sponsor's X (Twitter) handle opened the external link in the same browser tab.

The fix adds target="_blank" and rel="noopener noreferrer" to ensure external links open in a new tab while following security best practices.

This improves user experience by allowing users to remain on the JSON Schema website while viewing external profiles.

Does this PR introduce a breaking change?

No

@Surajiitmjnu Surajiitmjnu requested a review from a team as a code owner March 3, 2026 09:19
@github-project-automation github-project-automation bot moved this to Ready to review in PR - Triage Group Mar 3, 2026
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Hi @Surajiitmjnu! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Hi @Surajiitmjnu! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference, kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 0957ddd

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (dbfaf31) to head (0957ddd).
⚠️ Report is 96 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2310   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          633       672   +39     
  Branches       196       211   +15     
=========================================
+ Hits           633       672   +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Hi @Surajiitmjnu! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference, kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Hi @Surajiitmjnu! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference, kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready to review

Development

Successfully merging this pull request may close these issues.

🐛 Bug: External X (Twitter) Profile Link Opens in Same Tab Instead of New Tab

1 participant