fix(tools): eliminate groupBy flicker on page reload#2311
Open
waygeance wants to merge 1 commit intojson-schema-org:mainfrom
Open
fix(tools): eliminate groupBy flicker on page reload#2311waygeance wants to merge 1 commit intojson-schema-org:mainfrom
waygeance wants to merge 1 commit intojson-schema-org:mainfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Contributor
Author
|
Hi, could a maintainer please review this PR when convenient? Thanks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2311 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 672 672
Branches 211 211
=========================================
Hits 672 672 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix (UI state initialization & flicker fix)
Issue Number:
Screenshots/videos:
Screen.Recording.2026-03-03.at.7.36.32.PM.mov
If relevant, did you update the documentation?
N/A
Summary
This PR fixes a UI flicker issue on the Tooling page where the default grouping (
toolingTypes) briefly rendered before applying the selected value from URL query parameters.Root Cause
The
useToolsTransformhook:useEffectafter parsing router queryrouter.isReadyis initiallyfalse, the default state rendered first, causing visible flickerSolution
getInitialTransform()helper to centralize query parsing logicisReadyloading guard to prevent rendering until router is readyuseEffectResult
Does this PR introduce a breaking change?
Checklist
Please ensure the following tasks are completed before submitting this pull request.