Closed
Conversation
Fixes jsonapi-suite#8 This produces a failure when the json id doesn't match the record id or when there is no jsonapi_type present.
Contributor
Author
|
This would produce a failure in tests that looks like this: |
Contributor
Author
|
I am not 100% sure of the ramifications of ids not being present (when you are creating a record) but I think that wouldn't be a problem since you wouldn't be testing your input for a create action. |
Contributor
Author
|
If you want to merge this without the first commit (since you just merged my last PR), I am happy to rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is just to let you know I am working on this today. You may not want to version bump from the last merge until this one is done... assuming I get it right!