[Fix] prop-types: false positives since upgrading typescript-eslint to v8
#3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pplancq
changed the title
prop-types: positives since upgrading typescript-eslint to v8prop-types: false positives since upgrading typescript-eslint to v8
pplancq
force-pushed
the
bugfix/prop-types
branch
from
8e738fe to
99bd721
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3809 +/- ##
==========================================
+ Coverage 97.49% 97.75% +0.25%
==========================================
Files 132 132
Lines 9707 9707
Branches 3554 3555 +1
==========================================
+ Hits 9464 9489 +25
+ Misses 243 218 -25 ☔ View full report in Codecov by Sentry. |
|
The change looks good, but I'd prefer not to add code to support v8 of typescript-eslint when we're not even testing on v6 yet (see #3629, which i think subsumes this PR) |
|
Thanks for your reply, I was thinking more of this PR as a patch while waiting for full compatibility. I see that your PR has been going on for a while and I understand perfectly that some things take time. Now it's up to you to decide whether or not to add this modification. |
|
Obsoleted by #3629. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I'd like to start by thanking the amazing staff at this bookshop for all their hard work.
I'm thrilled to present my first contribution, which is a correction to the false positive of
prop-typesrule that have been raised since version v8 of typescript-eslint.Since version v8, it seems that the
typeParametersparameter no longer exists, so I've replaced it with thetypeArgumentsparameter, which is equivalent and all without causing a breaking change.Closes #3796