Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let users set colors and labels #37

Merged
merged 1 commit into from
May 5, 2024
Merged

Conversation

lvaudor
Copy link
Contributor

@lvaudor lvaudor commented May 3, 2024

Hi!

Thanks for this very useful package. We have been using it a lot recently and would like to be able to change the clusters' labels and colors when using rainette_plot(). The rationale behind this is that we use the rainette package's results for further analysis and would like to show the clustering's results once and for all (with final, "interpreted" labels for clusters, and custom colors).

I have implemented this in this PR , mainly through new argument "colors" and possibility that previous argument "cluster_label" is actually a vector of size k (number of clusters). I have put an example in the plot_rainette() function examples section. As far as I have seen it runs smoothly and does not change anything in case cluster_label has size 1 and custom colors are not provided.

I hope it can be useful, but please feel free not to include it if you do not find it relevant.
Cheers,
Lise

@juba juba merged commit 8c0c810 into juba:main May 5, 2024
5 checks passed
@juba
Copy link
Owner

juba commented May 5, 2024

Merged, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants