Update MidiMessageSequence::updateMatchedPairs to deal with note-on messages with velocity 0 #1468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essages with velocity 0
Contributor
Author
|
Sorry, deleted remote branch by mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current JUCE, both the
juce::MidiMessage::isNoteOnandjuce::MidiMessage::isNoteOffmethods allow users to decide how to regard notes with velocity 0. Here, I have also added this option to thejuce::MidiMessageSequence::updateMatchedPairsmethod.When
regardNoteOnEventsWithVel0AsNoteOffis set totrue(the default), it will maintain the original behavior of regarding note-on events with velocity 0 as note-off events.