Fix UB in VST plugins due to function prototype mismatch#1478
Closed
omartijn wants to merge 1 commit intojuce-framework:developfrom
Closed
Fix UB in VST plugins due to function prototype mismatch#1478omartijn wants to merge 1 commit intojuce-framework:developfrom
omartijn wants to merge 1 commit intojuce-framework:developfrom
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes undefined behaviour being triggered by the fact that the function signatures used for functions in VST plugins do not match those defined in the VST SDK.
Now that that's fixed some function pointer casts could also be removed (since the function types now actually match), so I've done that as well.