CMake: fix missing exported modules#1480
Closed
outkontroll wants to merge 1 commit intojuce-framework:developfrom
Closed
CMake: fix missing exported modules#1480outkontroll wants to merge 1 commit intojuce-framework:developfrom
outkontroll wants to merge 1 commit intojuce-framework:developfrom
Conversation
Member
|
Thanks! Merged here: 6f85c2c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like some of the modules were missing from a generated list used by CMake.
I'm using the compiled and installed JUCE libraries using CMake and when I tried to add an animation exactly like the one in examples/GUI/AnimatorsDemo.h I realized that CMake can't find the target "juce::juce_animation" to link to. The reason behind is that "juce_animation" is missing from the installed JUCE/install/lib/cmake//JUCEConfig.cmake file's _juce_modules list. The module "juce_midi_ci" was also missing. This file is generated from the JUCEConfig.cmake.in input file, that's why I modified this file.
After the (proposed) modification I was able to install and then link against juce::juce_animation.