Fix Text Editor’s caret being set incorrectly for trailing whitespaces #1581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input string was sanitised in constructor, resulting in stored string never containing any control characters.
The function was reporting the whitespace glyph's index instead of the index to the right of it.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to move Text Editor’s caret to the end of the last line of the text, it was being set one character to the left of the last whitespace character.
getGlyphIndexToTheRightOf is now reporting an invalid index for trailing whitespaces (as there’s nothing to the right of it), and the last character’s index for newline characters.
Also fixes newline characters not being detected correctly due to removing all control characters during string sanitising in SimpleShapedText’s constructor.