-
Notifications
You must be signed in to change notification settings - Fork 150
New scoreboard #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
New scoreboard #340
Conversation
import { ScoreboardV2Page } from "./pages/v2/ScoreboardV2Page"; | ||
import { TeamDetailPageV2 } from "./pages/v2/TeamDetailPageV2"; | ||
import { ChallengeDetailPageV2 } from "./pages/v2/ChallengeDetailPageV2"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have all components which use motion to be lazy loaded (like the existing score-board)
Motion stuff bloats up the bundle quit a bit. Would prefer to not have it loaded by default.
const AdminPage = lazy(() => import("./pages/AdminPage"));
const ScoreOverviewPage = lazy(() => import("./pages/ScoreOverview"));
const IndividualScorePage = lazy(() => import("./pages/IndividualScorePage"));
<thead> | ||
<tr className="bg-gray-50 dark:bg-gray-700"> | ||
<th className="p-3 text-center">#</th> | ||
<th className="p-3">Team</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these "user facing texts" (and the ones on the other pages) need to use the FormattedMessage to be translatable.
We should get this right from the beginnig, adding translation stuff in later usually is pretty painful
Description:
This PR introduces a new, modern V2 Scoreboard feature. It includes a real-time leaderboard and new drill-down views for both teams and individual challenges. All new functionality is implemented under the
/v2
path to allow for testing and feedback before it becomes the default.What's Done:
Backend (
balancer
service):GET /balancer/api/v2/challenges/{challengeKey}
)**Frontend (
balancer/ui
):New V2 Scoreboard Page (
/v2
)framer-motion
for smooth layout animations when team ranks change.New Team Detail Page (
/v2/teams/:team
)New Challenge Detail Page (
/v2/challenges/:key
)Next Steps:
How to Test Manually:
Run the project locally:
Populate with data:
http://localhost:8080/balancer
.Test the full user flow:
http://localhost:8080/balancer/v2
.