Add usage reference fields #1478
Open
+101
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 03fe889 in 44 seconds. Click for details.
- Reviewed
210lines of code in5files - Skipped
0files when reviewing. - Skipped posting
6draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. agents-api/agents_api/common/utils/usage.py:21
- Draft comment:
New tracking parameters (execution_id, transition_id, session_id, entry_id, provider) are added and included in the function docstring and call to create_usage_record. Confirm that these match the DB schema. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. agents-api/agents_api/queries/usage/create_usage_record.py:96
- Draft comment:
SQL query and function signature are updated with new fields; ensure parameter order in the query matches the params list. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. memory-store/README.md:12
- Draft comment:
The README update clearly documents the new usage table columns, which improves clarity for future migrations. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. memory-store/migrations/000042_usage_reference_fields.up.sql:4
- Draft comment:
Migration script correctly adds new columns and creates indexes. Consider using CREATE INDEX CONCURRENTLY for production environments if downtime is a concern. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
5. memory-store/migrations/000042_usage_reference_fields.down.sql:3
- Draft comment:
Down migration properly removes the new columns and drops the corresponding indexes. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
6. agents-api/agents_api/common/utils/usage.py:29
- Draft comment:
Typo: It looks like there's an extra colon in the function signature. The closing line reads): -> None:. It should likely be) -> None:. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_YHqFwlycLjPqvwqo
You can customize 
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Summary
Testing
poetry run poe formatpoetry run poe lintpoetry run poe typecheck(fails: KeyboardInterrupt)poetry run poe test(fails: Aborted)poetry run poe check(fails: Sequence aborted)https://chatgpt.com/codex/tasks/task_e_6846e15d915083219cbc49199bf5a298
PR Type
enhancement, documentation
Description
Add new reference fields to the
usagetable for better tracking.execution_id,transition_id,session_id,entry_id,provider.Update usage tracking utilities to support new fields.
Document new columns in the project README.
Changes walkthrough 📝
000042_usage_reference_fields.up.sql
Add reference columns and indexes to usage tablememory-store/migrations/000042_usage_reference_fields.up.sql
usagetable:execution_id,transition_id,session_id,entry_id,provider.providercolumn.000042_usage_reference_fields.down.sql
Remove reference columns and indexes from usage tablememory-store/migrations/000042_usage_reference_fields.down.sql
usagetable.create_usage_record.py
Add reference fields to usage record creationagents-api/agents_api/queries/usage/create_usage_record.py
usage.py
Support reference fields in usage tracking utilitiesagents-api/agents_api/common/utils/usage.py
track_usageandtrack_embedding_usageto accept and forwardnew reference fields.
create_usage_record.README.md
Document new usage table reference columnsmemory-store/README.md
usagetable.