Skip to content

Fix a bug in the swap optimization #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix a bug in the swap optimization #44

merged 1 commit into from
Jan 6, 2025

Conversation

davidanthoff
Copy link
Member

This fixes both a correctness error and presumably also a memory leak.

NHDaly
NHDaly approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great find.

I think you're definitely right about this. I just reread the original commit that introduced this optimization, and I'm pretty sure it was just an oversight:
9a96f9d

Thanks David! :)

@davidanthoff davidanthoff merged commit 813a66b into master Jan 6, 2025
18 checks passed
@davidanthoff davidanthoff deleted the fix-optimization-bug branch January 6, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHDaly NHDaly NHDaly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidanthoff @NHDaly