Fix UndefVarError for PkgEntry

[visr]

Related to #294, avoids always processing all packages locally when using a custom JULIA_DEPOT_PATH.

The language server showed this log:

┌ Error: Symbol cache downloading: Failed to identify which packages to omit based on the General registry.
│ All packages will be processsed locally
│   err =
│    UndefVarError: `PkgEntry` not defined in `SymbolServer`
│    Suggestion: check for spelling errors or missing imports.
└ @ SymbolServer 

This UndefVarError lead to always erroring on the side of caution as mentioned here:

SymbolServer.jl/src/SymbolServer.jl

Lines 114 to 122 in 2201c26

	try
	remove_non_general_pkgs!(to_download)
	catch err
	# if any errors, err on the side of caution and mark all as private, and continue
	@error """
	Symbol cache downloading: Failed to identify which packages to omit based on the General registry.
	All packages will be processsed locally""" err
	empty!(to_download)
	end

EDIT: it doesn't seem to solve the whole problem.

[pfitzseb]

Thanks!

[flexagoon]

@pfitzseb could you please merge this? The issue also has a side effect of always writing Pkg logs to ~/.julia regardless of the depot path, so it's pretty annoying

[visr]

Would be great to have this merged.

[pfitzseb]

This doesn't actually fix the issue on 1.6 or earlier:

julia> VERSION
v"1.6.7"

julia> using Pkg.Registry: PkgEntry
ERROR: UndefVarError: PkgEntry not defined

[visr]

Now this empty Dict is the same type as reg["packages"]. The difference was already handled in remove_non_general_pkgs!.

[visr]

Ok I've addressed that now.

Running this code locally still results in get_general_pkgs() being empty since my depot isn't in my homedir. I guess that means this doesn't fix #294, just a surface issue on top?

See also this discussion: #263 (comment)

How can we better find the General registry?