V5 #1
V5 #1
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| @@ -26,7 +26,7 @@ describe("HerokuEmbeddingModel", () => { | |||
| describe("Constructor", () => { | |||
| it("should initialize with correct properties", () => { | |||
| expect(model.modelId).toBe(testModel); | |||
| expect(model.specificationVersion).toBe("v1"); | |||
| expect(model.specificationVersion).toBe("v2"); | |||
There was a problem hiding this comment.
Bug: Heroku Embedding Model Version Uncertainty
The HerokuEmbeddingModel constructor test was updated to expect specificationVersion 'v2'. It's unclear if 'v1' or 'v2' is the correct version for this model after the AI SDK v5 migration.
| } | ||
| const supportedChatModels = [ | ||
| "claude-3-5-sonnet-latest", | ||
| "claude-4-sonnet", |
There was a problem hiding this comment.
Bug: Duplicate Model Entry in Supported List
The supportedChatModels array includes 'claude-4-sonnet' twice, creating a redundant entry in the list of supported models.
| if (options.providerOptions && | ||
| Object.keys(options.providerOptions).length > 0) { | ||
| console.warn("providerOptions are not supported for Heroku embedding models. Ignoring provided options."); | ||
| } |
There was a problem hiding this comment.
Bug: Signal Handling Delay in Embed Function
The doEmbed function's abort signal check is not the very first executable statement, allowing minimal processing before an aborted request is detected.
Migrate to ai-sdk v5