Add methods for content equals comparision (#1432)#1485
Closed
btrajkovski wants to merge 1 commit intojunit-team:mainfrom
Closed
Add methods for content equals comparision (#1432)#1485btrajkovski wants to merge 1 commit intojunit-team:mainfrom
btrajkovski wants to merge 1 commit intojunit-team:mainfrom
Conversation
btrajkovski
changed the title
btrajkovski
force-pushed
the
assert-content-equals
branch
from
7e7d297 to
3944ff1
Compare
Contributor
|
JUnit 4 is now in maintenance mode. At this point, only critical bugs and security issues will be fixed. The team has therefore decided to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am opening this PR, because #1439 was stuck on review. I fixed the review comments from that PR.
Also after discussions #1439 (comment) I am dropping string length comparison. Javadocs for this document was change a bit to follow assertEquals style and I've added one more unit test for when expected is null.