-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Provide mechanism for managing resources across engines and executions #4281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f6fe9f1
to
02ef45b
Compare
I’ve drafted an initial version 02ef45b , but I think there’s still a lot of room for improvement. Even though I’ve been studying, I find it quite challenging. PS. While resolving a git conflict, I accidentally included the commit history from the main branch, So i create a new PR 😁 |
I think you must be very busy with the release of version 5.12 M1. |
I think I sounded a bit too weak.
|
junit-jupiter-api/src/main/java/org/junit/jupiter/api/extension/ExtensionContext.java
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/junit/platform/engine/support/store/NamespacedHierarchicalStore.java
Show resolved
Hide resolved
junit-platform-engine/src/main/java/org/junit/platform/engine/Namespace.java
Outdated
Show resolved
Hide resolved
junit-platform-engine/src/main/java/org/junit/platform/engine/Namespace.java
Outdated
Show resolved
Hide resolved
junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/DefaultLauncher.java
Outdated
Show resolved
Hide resolved
...platform-launcher/src/main/java/org/junit/platform/launcher/core/DefaultLauncherSession.java
Outdated
Show resolved
Hide resolved
...piter-engine/src/main/java/org/junit/jupiter/engine/descriptor/AbstractExtensionContext.java
Outdated
Show resolved
Hide resolved
c9d5ac0
to
7d98e9a
Compare
junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/LauncherFactory.java
Outdated
Show resolved
Hide resolved
...orm-launcher/src/main/java/org/junit/platform/launcher/core/EngineExecutionOrchestrator.java
Outdated
Show resolved
Hide resolved
7b47567
to
d72090c
Compare
platform-tests/src/test/java/org/junit/platform/launcher/core/DefaultLauncherTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the store from the discovery process sounds like a good idea.
As the next step, I will proceed with the following task.
- Tests for Jupiter, Suite engine, EngineTestKit etc.
Thank you, Marc!
junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/DefaultLauncher.java
Show resolved
Hide resolved
...platform-launcher/src/main/java/org/junit/platform/launcher/core/DefaultLauncherSession.java
Show resolved
Hide resolved
...platform-launcher/src/main/java/org/junit/platform/launcher/core/DefaultLauncherSession.java
Show resolved
Hide resolved
junit-platform-launcher/src/main/java/org/junit/platform/launcher/LauncherSession.java
Show resolved
Hide resolved
While working on the tests, I have a question. As per your guidance, I am adding tests for Since the main focus of this PR is adding request-level and session-level stores, I am designing the tests around that. The Do you think any additional tests are needed for PS. I truly appreciate how you not only explain things but also implement the code to make communication more efficient—it’s been incredibly helpful. 👍🏻 |
...testFixtures/java/org/junit/platform/launcher/core/NamespacedHierarchicalStoreProviders.java
Outdated
Show resolved
Hide resolved
I was thinking about a very basic tests that verifies that |
Issue: junit-team#2816 Signed-off-by: yongjunhong <[email protected]>
Issue: junit-team#2816 Signed-off-by: yongjunhong <[email protected]>
Issue: junit-team#2816
Issue: junit-team#2816
Issue: junit-team#2816 Signed-off-by: yongjunhong <[email protected]>
Issue: junit-team#2816
platform-tests/src/test/java/org/junit/platform/launcher/core/LauncherFactoryTests.java
Show resolved
Hide resolved
platform-tests/src/test/java/org/junit/platform/launcher/core/LauncherFactoryTests.java
Outdated
Show resolved
Hide resolved
@YongGoose I'll discuss this PR with the team on Friday and will leave it open until then. |
…LauncherFactoryTests.java Co-authored-by: Marc Philipp <[email protected]>
…LauncherFactoryTests.java Co-authored-by: Marc Philipp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation work is always challenging. 🤯 I’ve added comments where I felt additional explanation or improvements might be helpful.
Thank you, as always, for taking the time to provide feedback on my work! 🙇🏻
documentation/src/test/java/example/sharedresources/SharedResourceTest.java
Outdated
Show resolved
Hide resolved
documentation/src/docs/asciidoc/user-guide/advanced-topics/launcher-api.adoc
Show resolved
Hide resolved
documentation/src/docs/asciidoc/user-guide/advanced-topics/launcher-api.adoc
Show resolved
Hide resolved
documentation/src/docs/asciidoc/user-guide/advanced-topics/launcher-api.adoc
Outdated
Show resolved
Hide resolved
documentation/src/docs/asciidoc/user-guide/advanced-topics/launcher-api.adoc
Outdated
Show resolved
Hide resolved
documentation/src/test/java/example/session/CloseableServerSocket.java
Outdated
Show resolved
Hide resolved
@marcphilipp In the previous method, we had to add new methods every time we wanted to extend functionality, which was a drawback. However, with these changes, the flexibility for expansion has significantly improved. Would it be okay to ask if there were any further discussions about this PR during the team meeting? |
@mpkorstanje @leonard84 Is this something that can be adopted in the Cucumber/Spock engines? |
@YongGoose Thank you for all your hard work! 👍 🙇 |
This project was personally very challenging for me. In the beginning, there were moments when I considered giving up, but instead of wasting time on such thoughts, I decided to put in even more effort and give it my all. As I kept pushing forward, two months flew by, and I was finally able to complete the task. I will do my best in the next task as well, just as I did with this one. 💪🏻 |
Sure! We took a few steps back and discussed whether we need this at all. In the end, we decided we do since it "resource management" was the reason for introducing |
Resolves #2816
Overview
EngineDiscoveryRequest and TestPlanExecutionRequestI hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations