Skip to content

feat: Add user ID filter to authentication page #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tinkerer-shubh
Copy link
Contributor

@tinkerer-shubh tinkerer-shubh commented Jun 5, 2025

Motivation

fixes: #1291

@tinkerer-shubh
Copy link
Contributor Author

tinkerer-shubh commented Jun 6, 2025

Screenshot from 2025-06-06 14-55-10

Screenshot from 2025-06-06 14-55-30

this is what it looks like right now 🎉(will tackle the merge conflicts 👍)

Copy link
Contributor

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@tinkerer-shubh
Copy link
Contributor Author

Could you please handle the merge conflict? I’m a bit stuck at that step. Thank you! 🙏

@peterpeterparker
Copy link
Contributor

peterpeterparker commented Jun 6, 2025

Daaarn, I think I screwed the merge conflicts (🤦‍♂️), sorry for that @tinkerer-shubh .

In Users.svelte you should reintroduce the import of listParamsStore and also use it for $.filter.

UPDATE: I managed to resolve this mistake. Committed in the branch.

@tinkerer-shubh
Copy link
Contributor Author

merge conflicts resolved?! nicee 🎉

thanks for the help :)

(merge conflicts scare me 🐢 jk jk)

@tinkerer-shubh tinkerer-shubh marked this pull request as ready for review June 6, 2025 19:02
@peterpeterparker
Copy link
Contributor

Amazing!

There is one minor issue (I think filter is unused following some merge conflicts), I'll fix that after merge.

Thanks a lot for the help.

@peterpeterparker peterpeterparker merged commit 277c8a0 into junobuild:main Jun 7, 2025
4 checks passed
@tinkerer-shubh tinkerer-shubh deleted the feature/user-filter-authentication branch June 7, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter user id for authentication
2 participants