-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load plotly.js from CDN rather than by inclusion #439
base: master
Are you sure you want to change the base?
Conversation
Greatly reduces notebook file size by setting `connected=True` in the call to `init_notebook_mode`, as suggested here: https://github.com/plotly/plotly.py/blob/master/plotly/offline/offline.py#L92 . Fixes jupyter-incubator#438.
Hey, thanks so much for sending this 👍 We have autovizwidget listing plotly version requirements here:
|
To support the connected=True argument to init_noteboook_mode.
Thank you for the review! And good catch. I modified the two files to update the minimum plotly version required. |
LGTM. Waiting for @apetresc's feedback. |
Did some manual testing and everything seems to work fine 😄 That being said, I think it would be optimal to allow this to be configurable in The tradeoff being made is that if we force I can make this change, just wanted to get @aggFTW's approval (on both the idea and the name of the key in |
Yes, that sounds good! 👍 Will you merge then? |
Greatly reduces notebook file size by setting
connected=True
in the call toinit_notebook_mode
, as suggested here. Fixes #438.